Skip to content
  • Garry Tan's avatar
    b3e94a3f
    v1.91.279.0 eval:select exemptions and ETHOS.md registration (#3499),... · b3e94a3f
    Garry Tan authored
    
    v1.91.279.0 eval:select exemptions and ETHOS.md registration (#3499), below-floor review rulings (#3504, #3485), Windows curation, GSTA-121 follow-ups (#3515)
    
    * Eval selection exemptions, review-floor rulings and the GSTA-121 follow-ups
    
    Release metadata (NOTICE.md, LICENSE, licenses/**) no longer restores the
    full paid gate and ETHOS.md is registered under the two prompts that read
    it (#3499). docs/review-policy.md records the six finding classes #3485
    and #3504 ruled below the floor and the review army's lead judgment
    applies the table; the floor itself is unchanged. The Windows curation
    moves test/pregate-remote-stamp-only.test.ts to KNOWN_WINDOWS_INCOMPATIBLE
    (#3485). From GSTA-121: Blast radius in docs/skills.md and the merge-ask
    template, the 11-digit run-id exemption from pii.phone.e164 after a run
    word, relative string literals as import-graph edges, and a ubi-runner
    pack that never tars the live .git.
    
    Co-authored-by: default avatarcapy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
    
    * fix: pre-landing review fixes
    
    Red Team pass 1 (all below the floor): an 11-digit span with a leading 1
    after a run word is a US or Chinese national number, not a run id, and
    reports again; ubi-runner pack removes its temporary repository when it
    fails and replays branch.* with remote.* so a branch's upstream resolves
    on the VM; the conservative-refusal example in docs/review-policy.md
    reads in the refusing direction; the touchfiles header names why ETHOS.md
    sits only under the two prompts that quote it. Step 6's selection found
    captain/templates/merge-ask.md as the one unknown dependency of this PR
    and registered captain/templates/** in FREE_ONLY_PR_FILES (#3499).
    
    Co-authored-by: default avatarcapy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
    
    * fix: pre-landing review fixes (pass 2)
    
    The cmd_pack EXIT trap bakes the temp path in: a set -e failure unwinds
    the function before the trap runs and a local $tmp is unset there, so
    the old form leaked the snapshot. The leak test creates TMPDIR where the
    pack reads it and asserts the failure is the missing index. CHANGELOG
    examples no longer spell a full national number.
    
    Co-authored-by: default avatarcapy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
    
    * fix: adversarial review fixes
    
    The pack snapshot carries the index's staged blobs as a pack of their own,
    so a VM write-tree (gstack-wtree) can read a staged file the way the old
    .git tar allowed; git init runs with --template= and gc.auto=0 and a
    valueless remote/branch key replays as true. scripts/harness-version.json
    re-pins scripts/test-pr-profile.ts after the captain/templates/** entry.
    The run-id exemption reads the same way in the scanner and gstack-post:
    an 11-digit span after a run word is a run id (the leading-1 exclusion
    from the Red Team pass contradicted gstack-post's tested contract and the
    ruling that a run id is not a phone number), with the residual named in
    the comment, the docs and the CHANGELOG. The #3499 pins move to their own
    test so the boundary test stays under its default budget. Docs audit:
    TESTING_INTERNALS names RELEASE_METADATA_FILES and captain/templates/**,
    docs/captain.md names Blast radius.
    
    Co-authored-by: default avatarcapy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
    
    * fix: pre-landing review fixes (pass 4)
    
    The pack's staged-blob list comes from the copied index, holds only blobs
    staged against HEAD (not every tracked blob), skips gitlinks whose commit
    the superproject lacks, and dies with its own message when pack-objects
    fails. The live-checkout test covers a gitlink entry and a valueless
    remote key replayed as true. CHANGELOG names the staged-blob carry.
    
    Co-authored-by: default avatarcapy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
    
    * fix: pre-landing review fixes (pass 5)
    
    The pack's blob list is the copied index's blobs that HEAD's tree lacks,
    so an intent-to-add entry's empty blob and the stages of an unmerged entry
    travel too (the HEAD-only diff list dropped both); gitlinks still skip.
    The live-checkout test adds an intent-to-add entry, which the VM fsck
    assertion covers.
    
    Co-authored-by: default avatarcapy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
    
    ---------
    
    Co-authored-by: default avatarcapy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
    b3e94a3f
    v1.91.279.0 eval:select exemptions and ETHOS.md registration (#3499),...
    Garry Tan authored
    
    v1.91.279.0 eval:select exemptions and ETHOS.md registration (#3499), below-floor review rulings (#3504, #3485), Windows curation, GSTA-121 follow-ups (#3515)
    
    * Eval selection exemptions, review-floor rulings and the GSTA-121 follow-ups
    
    Release metadata (NOTICE.md, LICENSE, licenses/**) no longer restores the
    full paid gate and ETHOS.md is registered under the two prompts that read
    it (#3499). docs/review-policy.md records the six finding classes #3485
    and #3504 ruled below the floor and the review army's lead judgment
    applies the table; the floor itself is unchanged. The Windows curation
    moves test/pregate-remote-stamp-only.test.ts to KNOWN_WINDOWS_INCOMPATIBLE
    (#3485). From GSTA-121: Blast radius in docs/skills.md and the merge-ask
    template, the 11-digit run-id exemption from pii.phone.e164 after a run
    word, relative string literals as import-graph edges, and a ubi-runner
    pack that never tars the live .git.
    
    Co-authored-by: default avatarcapy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
    
    * fix: pre-landing review fixes
    
    Red Team pass 1 (all below the floor): an 11-digit span with a leading 1
    after a run word is a US or Chinese national number, not a run id, and
    reports again; ubi-runner pack removes its temporary repository when it
    fails and replays branch.* with remote.* so a branch's upstream resolves
    on the VM; the conservative-refusal example in docs/review-policy.md
    reads in the refusing direction; the touchfiles header names why ETHOS.md
    sits only under the two prompts that quote it. Step 6's selection found
    captain/templates/merge-ask.md as the one unknown dependency of this PR
    and registered captain/templates/** in FREE_ONLY_PR_FILES (#3499).
    
    Co-authored-by: default avatarcapy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
    
    * fix: pre-landing review fixes (pass 2)
    
    The cmd_pack EXIT trap bakes the temp path in: a set -e failure unwinds
    the function before the trap runs and a local $tmp is unset there, so
    the old form leaked the snapshot. The leak test creates TMPDIR where the
    pack reads it and asserts the failure is the missing index. CHANGELOG
    examples no longer spell a full national number.
    
    Co-authored-by: default avatarcapy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
    
    * fix: adversarial review fixes
    
    The pack snapshot carries the index's staged blobs as a pack of their own,
    so a VM write-tree (gstack-wtree) can read a staged file the way the old
    .git tar allowed; git init runs with --template= and gc.auto=0 and a
    valueless remote/branch key replays as true. scripts/harness-version.json
    re-pins scripts/test-pr-profile.ts after the captain/templates/** entry.
    The run-id exemption reads the same way in the scanner and gstack-post:
    an 11-digit span after a run word is a run id (the leading-1 exclusion
    from the Red Team pass contradicted gstack-post's tested contract and the
    ruling that a run id is not a phone number), with the residual named in
    the comment, the docs and the CHANGELOG. The #3499 pins move to their own
    test so the boundary test stays under its default budget. Docs audit:
    TESTING_INTERNALS names RELEASE_METADATA_FILES and captain/templates/**,
    docs/captain.md names Blast radius.
    
    Co-authored-by: default avatarcapy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
    
    * fix: pre-landing review fixes (pass 4)
    
    The pack's staged-blob list comes from the copied index, holds only blobs
    staged against HEAD (not every tracked blob), skips gitlinks whose commit
    the superproject lacks, and dies with its own message when pack-objects
    fails. The live-checkout test covers a gitlink entry and a valueless
    remote key replayed as true. CHANGELOG names the staged-blob carry.
    
    Co-authored-by: default avatarcapy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
    
    * fix: pre-landing review fixes (pass 5)
    
    The pack's blob list is the copied index's blobs that HEAD's tree lacks,
    so an intent-to-add entry's empty blob and the stages of an unmerged entry
    travel too (the HEAD-only diff list dropped both); gitlinks still skip.
    The live-checkout test adds an intent-to-add entry, which the VM fsck
    assertion covers.
    
    Co-authored-by: default avatarcapy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
    
    ---------
    
    Co-authored-by: default avatarcapy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Loading